Chen Yuheng

Results 22 comments of Chen Yuheng

since this MR introduce a new crate dependency, and users can easily implement this helper method in their code. I'm not sure wether we should provide this in yaml crate

pls rebase this MR to fix CI

I think (theoretically) it is better to wrap internal map (e.g. LinkedHashMap) with a proxy layer to hide its implementation. Also make it easier to switch to other map implementation,...

it seems that linked-hash-map is quite stable (and used by several popular crates), and we have no reason the switch to a new crate.

This library currently support several standard tag directives, e.g. `!!str`. But this feature is seldom used, can you give me some typical use cases? And how other YAML libraries support...

Thanks for the detailed discussion! Here's my options: - Handling tags with hooks (in the same way in Python or Ruby) is easy, maybe it can be added in the...

@DeltaEvolution propose a new API for tag parsing (see #37 ). It looks OK for me. Any opinion for the PR? @flyx @ioben

The API enhancement looks good for me. One little problem, maybe we should move `dump_node` into a helper in examples, instead of just marking it as `pub`.

@DeltaEvo you can try rebasing your pr, master passes CI now.

@DeltaEvo Seems `clippy` breaks on newest nightly... https://github.com/Manishearth/rust-clippy/issues/1371