yaml-rust icon indicating copy to clipboard operation
yaml-rust copied to clipboard

Published 20 hours ago • verified publisher icon chyh1990

Scalar parser

Open DeltaEvo opened this issue 9 years ago • 15 comments

Fix #35

DeltaEvo avatar Oct 10 '16 16:10 DeltaEvo

What do you think about this pr @chyh1990 ?

DeltaEvo avatar Oct 24 '16 23:10 DeltaEvo

The API enhancement looks good for me. One little problem, maybe we should move dump_node into a helper in examples, instead of just marking it as pub.

chyh1990 avatar Nov 04 '16 08:11 chyh1990

@chyh1990 How do you want to move dump_node as helper ?

DeltaEvo avatar Nov 05 '16 17:11 DeltaEvo

@chyh1990 the build is breaked https://travis-ci.org/chyh1990/yaml-rust/jobs/176486614

DeltaEvo avatar Nov 16 '16 20:11 DeltaEvo

@chyh1990 any news about the build system ?

DeltaEvo avatar Dec 07 '16 22:12 DeltaEvo

@DeltaEvo you can try rebasing your pr, master passes CI now.

chyh1990 avatar Dec 08 '16 06:12 chyh1990

@chyh1990 I think I'm unlucky

DeltaEvo avatar Dec 08 '16 15:12 DeltaEvo

@DeltaEvo Seems clippy breaks on newest nightly...

https://github.com/Manishearth/rust-clippy/issues/1371

chyh1990 avatar Dec 09 '16 02:12 chyh1990

@chyh1990 The issue on clippy is fixed and I rebased my Pull Request

DeltaEvo avatar Dec 20 '16 16:12 DeltaEvo

@chyh1990 or @dtolnay, what is missing in this PR from being merged ? Thank you

DeltaEvo avatar Jun 25 '17 22:06 DeltaEvo

merge failed ?

zuowenjian avatar Apr 18 '18 05:04 zuowenjian

I rebased this branch in a separate PR: https://github.com/chyh1990/yaml-rust/pull/135

gyscos avatar Aug 06 '19 23:08 gyscos

Given that #135 replaces this PR, should this PR be closed?

jaesharp avatar Oct 01 '19 02:10 jaesharp

@dtolnay, what is missing in this PR from being merged ?

I am not involved in this crate, since it is no longer used by serde_yaml.

dtolnay avatar Aug 01 '22 23:08 dtolnay