Lorenzo Chierici

Hi @drewejohnson, thanks for starting this review. I've begun to address your comments/suggestions. I can see how `batchwise` might create some confusion. The routine acts in between a transport and...

@drewejohnson thanks, I've addressed most of your comments and changed the name to `reactivity_control`, which I like it and think also is appropriate. Regarding the adaptive search routine, as I...

@drewejohnson Thank you for your comments. Regarding your concerns: - **Infinite loop**: As long as the `search_for_keff` bracketed algorithm returns two arguments (meaning that the search have failed to bound...

@drewejohnson I thought a bit more about the **reactivity control** definition and added a setter method that hopefully goes in the right direction. Now users can instantiate directly their own...

Hi @gridley , Is this bit here in `_load_previous_results` method: ```python `if comm.size != 1: prev_results = self.prev_res self.prev_res = Results() mat_indexes = _distribute(range(len(self.burnable_mats))) for res_obj in prev_results: new_res =...

@drewejohnson @gridley , I think I've figured out what's happening here: `self.prev_res = Results()` does not reinitialize to a null `Results` class (as the default argument in `results.py` is `filename='depletion_results.h5'`),...

Hi @gridley and thanks for your comment. I agree this can be solved in many different ways, but this implementation relies on recent **TransferRates** implementation to add a new term...

@gridley thanks for getting back to this. In regards to your concerns: 1. What I've added here is a further term to the Bateman equation that balances the redox of...

Hi @gridley thanks again for taking a look at this: 1. Not that I know of, I derived this myself, but it's a simple oxidation state balance equation. Haven't really...

Hi @drewejohnson and thanks again. > Apologies again for my delay. Life has been a bit hectic and I finally found time to review this. > > Thank you for...