Ran Tao comments

Results 38 comments of


                                            Ran Tao

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

@MartijnVisser thanks. i rebased it. ci passed. PTAL

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

@MartijnVisser I think we can fix it completely. i will fix this and update pr ASAP. Sorry for my mistake. thanks.

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

![image](https://user-images.githubusercontent.com/11287509/218948092-281c16c7-eafa-41a5-93b6-185cea0330cb.png)

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

> hi. @MartijnVisser i have updated the pr. And i searched the source code didn't find any other occurs using `org.apache.commons.collections`. PTAL. thanks. hi. @MartijnVisser please take a look ?

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

@MartijnVisser thanks for explanations. make sense. we will be watching closely about kafka externalization.

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

@MartijnVisser hi, Martijn, https://issues.apache.org/jira/browse/FLINK-30859 has been resolved. Can you help me to check this pr?

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

Hi @MartijnVisser thanks. it seems like some recent code introduced a old usage. I updated it. ![image](https://github.com/apache/flink/assets/11287509/4dc5e34e-26fd-4a92-80da-a98083d54dc8) ![image](https://github.com/apache/flink/assets/11287509/b44143ef-252b-4436-969f-5cb7f4430ae6) please check.

[FLINK-30274] Bump commons-collections 3.x to commons-collections4

@MartijnVisser There is a circular reference. ci failed becase flink-python kafka test case failed. flink-python test case reference flink-sql-connector-kafka（not uber jar, without commons-collections class）, so search it in flink and...