Ran Tao

Results 38 comments of Ran Tao

@tzulitai hi, Gordon. It's been a long time, please let me know if you have any concerns, I will fix it ASAP. thanks.

> @chucheng92 Can you please rebase your PR? Yes, I have rebased it and passed ci. If you have time, pls help to review it again. thanks a lot.

Hi,guys。I use null String "" to caculate Keccak value. e.g.:SHA3-224("") and result will be "6b4e03423667dbb73b6e15454f0eb1abd4597f9a1b078e3f5b5a6bc7".

> This is looking pretty good. Since implementing FLIP-297 is assigned to @chucheng92, we should get his input as well! > > @jeyhunkarimov have you signed up for the Flink...

> The code is very ugly, please do not review it, I will refactor it later. you can create a DRAFT PR when PR is not ready.

@caicancai A suggestion, don’t directly @/pin committers to review for you. This will affect other committers or contributors’ participation in your reviews.

@caicancai please use correct/proper commit name when you fix code-reivews to add a new commit.

@caicancai I have created a commit based on your PR. you can pick and take a look. https://github.com/chucheng92/calcite/commit/12cd99c8b1397b643b6d842f58d0331f54b7cb09