Christian Beiwinkel

Results 182 comments of Christian Beiwinkel

> looks good @chrstnbwnkl . it's fine for now to stay as close to vroom api as you did for the object model. > > just a couple of things...

Thanks for your time to check this (and for this very convenient library of course)! True, one could easily convert to string, so it's more convenience feature than anything else....

Sorry for letting this go stale again for so long... I checked tags of an .osm file I had lying around and you're right indeed: tags where values include a...

As far as I can tell the functionality to load the coastline from a shapefile introduced in #47 has been removed in #102 . I am still running into problems...

I have picked this up again, and apart from resolving merge conflicts, I did two things: - move the request option from `/blind_user_mode` to `/costing_options/type`, making use of an existing...

@grzezlo I understand how these ASCII maps are hard to comprehend only using screen readers, glad I could help here. It's impressive how you navigate a code base as large...

@grzezlo There are bi-weekly meetings Mondays and Wednesdays where we go over PRs and give and get feedback on them. If you are interested, you can join one of these...

After some review rounds now, the only big question remaining is how to enable announcements for passing pedestrian traffic signals without messing with `stop_impact` on `DirectedEdge` and without compromising backwards...

From my side this is all set. In the last CI run, the tests I added failed only in the build release (and I wasn't able to reproduce it locally)....

Okay, seems like I have to have another look at those tests