Chris comments

Results 9 comments of


                                            Chris

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben here’s the PR that we discussed over Slack

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben thanks for the review. I'll update the theme to use `select.clear.hover.color` and `select.clear.hover.background` instead of `select.clear.hoverIndicator`. Do you just want me to style the `ClearButton` component in `src/js/components/Select/SelectContainer.js` using...

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben Thinking about this more... Since `plain` is deprecated when using the new button `kind`, can `hoverIndicator` be kept to style the hover state and we just update the documentation...

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben okay, will make the update

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben PR updated

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben Thanks for the review. Yeah I had the same thought about using styled components and just wanted to verify w/ you before adding (see my earlier comment above). Will...

Add ability to style the Clear option background and color on hover, in the Select component

@jcfilben Updated, let me know what you think

Cross-domain tracking

For now, my team was able to use `ReactGA.ga` to enable cross-domain tracking this way: ```javascript ReactGA.initialize(UA-YOUR-TRACKING-ID, { gaOptions: { allowLinker: true }, }); ReactGA.ga('require', 'linker'); ReactGA.ga('linker:autoLink', ['voleer.com', 'voleer.io']); ```...