christianwen

Results 9 comments of christianwen

# **Proposal** ## **Problem** The issue is in `src/pages/home/report/ReportActionCompose.js`. This is due to when we split/request money for the first time for a new group/person, the `this.props.reportActions` is loaded with...

would it be more suitable for the `composer not focused when creating a new chat` to be a separate bug issue since that's not really included in the scope of...

I believe the solution to use `_.size(this.props.reportActions) === 0` that relies on the observed behavior of > when ReportScreen Is loaded with no chat _.size(this.props.reportActions) is always 0 and after...

# **Proposal** ## **Solution** We'll make use of `showSoftInputOnFocus` of React Native Text Input and `inputMode` of web input to achieve the intended behavior. In `src/pages/home/report/ReportActionCompose.js` ```diff this.state = {...

# **Proposal** ## **Problem** For the issue in Android, it's due to the code in `react-native-onyx` -> `lib/metrics/index.native.js` -> `function decorateWithMetrics` is expecting that the `func` passed in is a...

Hi, @Santhosh-Sellavel in my proposal I've also put the solution to address the crash on the web by fixing the `decorateWithMetrics` noop. By `their solution doesn't address the issue`, do...

@Santhosh-Sellavel can you help attach the log of the crash after you apply the suggestion is it the same log as in the original description? thanks

@Santhosh-Sellavel confirming with you, you are modifying it in the `node_modules/react-native-onyx/lib/metrics/index.web.js` after cloning repo `https://github.com/Expensify/App` locally to try right? if that's the case then it's not working because in `node_modules`,...

@Santhosh-Sellavel yeah I've checked, no more crash on any platform, screenshots attached below **iOS** ![simulator_screenshot_C9FE8B23-06B8-4EAB-B613-188E3EA78691](https://user-images.githubusercontent.com/21312517/189782704-f66e8554-5678-45d0-b9e0-1c546699853f.png) mWeb Mac Desktop app For Android and web I've already attached screenshots in https://github.com/Expensify/App/issues/10622#issuecomment-1234389410 Thanks!