Christian González

Results 6 comments of Christian González

It would be good if LABELS XML definition can be reworked to improve the behavior with FTS search.

The changes on this PR were previously discussed with @vuvova and @grooverdan at: https://github.com/MariaDB/server/pull/2928

@vuvova regarding your comment about optional parenthesis here: https://github.com/christian7007/server/commit/4c9ec8155eb9d72edc4a30560ff941d70e634eb5#r135239559. The first version I pushed for this PR allowing option parenthesis broke `main.parser` test at: https://github.com/MariaDB/server/blob/c0c1c80346b926ea1358aa512374d72d513299b0/mysql-test/main/parser.test#L116 Maybe I'm missing something, but...

I also updated some MTR tests, there are still some CI failures but after looking at them I don't think they are related with my changes.

Hey @vuvova, I just pushed a new version with the two minor changes, I'm not sure if it being a reserved word needs any other adjustment, I just updated the...

Thanks for the explanation! I can see some CI tests failing, but looking at the failures it doesn't look related with my changes and I can see the tests are...