Christian Thieme

Tests should be part of the module

2

Currently they are part of the example project.

HTML and Javascript code cleanup

3

- currently the html and javascript for the passkeys package is separated into multiple files which can be combined into one html and one javascript file for easier integration -...

- using a namespace for the functions - adapted urls and html

Code does not follow PEP8 Style guide

1

- use of white space is somewhat random - varying approaches in naming functions and variables - code quality could be improved by using an editor that supports PEP8 checks

API view response handling

1

The success/failure of a api call should depend on the status code returned by the view, not the response body. The response body should be for informational purposes only. Example:...

delKey and toggleKey throw exception on invalid id parameter.

1

They should handle invalid request data more gracefully by returning HTTP 400 status code.

Use standard django login functions

2

In the example project provde an example how to use the standard django login and admin login views since they do more than a simple call to login()

reg_complete view throws unspecific error

1

In case something goes wrong the view always returns a server error. The error handling should be more detailed and return meaningfull status codes.

Add administration integration to example project

1

For easier integration add an example howto add this to the example project

The repository contains multiple vendor packages for the sample project which are not necessary for implementation or can be referenced using a cdn - bootstrap - fontawesome - jquery -...