Christoph Pader
Christoph Pader
@lfkwtz conflicts resolved 👍
@lfkwtz just found a reliable way to measure the actual modal height, without the need to hardcode it. Let me know what you think and if everything works for you...
> looking good - able to close that coverage gap? Not sure how, if were not able to test this lib natively on iOS... Do you have an idea?
@lfkwtz do you think we can merge this? Absolutely no priority though..
I'm gonna try to continue working on the tests if i get the chance any time soon...
> looks like the team at lawnstarter is starting to work on this a bit more so maybe they will be able to help you get this in cc @alberto-mourao-lawnstarter...
gonna resolve merge conflicts soon
I think we can close this :) @tgolen
I also had the same problem with v8.0.0. I tried to patch [`[email protected]`](https://www.npmjs.com/package/react-native-screens/v/3.34.0) and it fails when files are renamed. For reproduction here are two two patch files, one which...
This can technically be fixed by adding the `--no-rename` option to the diff command in https://github.com/ds300/patch-package/blob/c7c63bf80b3c6b8640b933e20229121b4edfc100/src/makePatch.ts#L314-L321 (This is how i created my succeeding patch file btw) Is there any benefit...