Christoph Pader
Christoph Pader
@dominictb @mountiny this is ready for review and the prerequisite for https://github.com/Expensify/App/pull/53149
> @chrispader Can you pull `main` please? Then we're good to go. done! @dominictb
> Changes are simple and look good to me! I have some questions though: > > 1. I know it's not the main goal of the issue, but I'm curious...
> @chrispader what are we missing here? @rlinoz i don't think there's anything missing here, as long as testing and review are good i'm not on my macbook right now,...
@rlinoz merge conflicts resolved, this should be ready to go!
> @chrispader Can you update the `react-native-onyx` version here to the latest commit from [Expensify/react-native-onyx#602](https://github.com/Expensify/react-native-onyx/pull/602); and pull `main` as well? It kept failing iOS & Android builds. @dominictb done!
> Whoops. Seems like a bug with XCode 16.2 [mrousavy/nitro#422](https://github.com/mrousavy/nitro/issues/422). I managed to run it after manually changing the minimum deployment target of `NitroModules` to 16.0. @dominictb As Marc explained...
Just checked, but unfortunately there's no new Swift version with the fix so far. Let's hope the next Swift version will make it into the next Xcode version, fingers crossed...
@mountiny @dominictb i think this should be ready to merge? 🙌🏼
> @chrispader @dominictb did you confirm this works well for the hybrid app and standalone too? no changes in the oldApp required? @mountiny just tested it on HybridApp, everything works...