magicLAMP icon indicating copy to clipboard operation
magicLAMP copied to clipboard

Support https on s3

Open jimtaylor123 opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. S3.localhost is currently only http, but this breaks images on browsers like Brave and Safari that do not allow mixed content.

Describe the solution you'd like To be able to choose to run https on all services, not just php sites. Actually, just to run https everywhere and opt out of it to http if required.

Describe alternatives you've considered Using AWS s3 instead.

jimtaylor123 avatar Apr 09 '21 21:04 jimtaylor123

Nice idea!

Since you can't have a wildcard SSL certificate on a TLD (.localhost in magicLAMPs case), I'd have to add a suffix to all built-in services so we don't have to re-issue SSL certificates every time we add a service. This way we can have a wildcard SSL for *.magiclamp.localhost, then all services will automatically get SSL.

What are your thoughts on the suffix being .magiclamp.localhost instead of .localhost? The same would apply for the PHP services too, so example.80.localhost would become example.80.magiclamp.localhost.

chrisnharvey avatar Apr 09 '21 22:04 chrisnharvey

I can see how it's a bit ugly, but the option to have all https is only going to become more and more important. The only way I can think of making it less ugly is to have something shorter like example.80.my.localhost or example.80.ml.localhost (ml for magic lamp). I think my favourite is my.localhost. Perhaps this string could be a config value that defaults to magiclamp? On whether to make this the default option - you know the user base better than me. I wouldn't mind having to opt in to https everywhere instead of the other way round as long as opting in was just setting a config variable to true : )

jimtaylor123 avatar Apr 09 '21 22:04 jimtaylor123