Chris LoPresto

Results 10 comments of Chris LoPresto

@migbar Thanks and thanks! These are early days, so I think we should remove/merge components to arrive at something simple. Your outlined approach sounds good at first glance. As we...

I'm thinking we should have a `display` property that defaults to `'toggle'` but can be set to `'none'` or `'off'`... something like that.

The idea here is to provide a way to opt out of the automatic usage snippet. For example, we never want to see the usage snippets for things like the...

@ykaragol Thanks for the twiddle. A similar workaround to the one mentioned in https://github.com/yapplabs/ember-wormhole/issues/66 seems to do the trick: ```hbs {{#if isShowing}} {{#ember-tether target='#a-nice-person' targetAttachment='top left' attachment='bottom left' }} A...

@kasunvp There may have been a programmatic problem with the close behavior of nested modals because we weren't calling super in the `didInsertElement` and `willDestroyElement` hooks. That is fixed in...

@krisselden What do you think about a component property to opt into such a static container?

Could work in tandem with an override of `.$()`

@toranb Definitely. I think it's a very common use case. Implementing this will also help with key responders that require focus as well (e.g. `ESC` to close modal). We may...

This is definitely _not_ a recommended approach, as it would special case your test environment state and could therefore mask real bugs. But the ember-modal-dialog test suite does have a...

@gzurbach It's not directly documented, but you can specify `useEmberTether=false` to fall back to the `positioned-container`-based positioning. ``` hbs {{#modal-dialog useEmberTether=false}} I am a modal that will never use ember-tether....