Chris Krycho
Chris Krycho
Hmm, this is an interesting one. The book doesn’t talk about the `Drop` trait till 15.3, and the first time it brings up stack overflows is 15.6. Accordingly, we *definitely*...
I’ve reread this section and thought on it a bunch, and I think unfortunately this is going to have to stay in the “too much detail” bucket. It’s true that...
@dalance in all honesty I have not yet had a chance to dig into it—but I will do so this morning, and @carols10cents and I are chatting later today, so...
Thanks for filing the issue, and sorry you found that confusing! The text here says that you can use the `?` operator if you want the test to *fail* if...
Explicitly calling out the desired outcome makes sense. I think the specific phrasing around expecting the *test* to pass or fail is also not quite right, though: after all, in...
I let this one simmer for a while, as promised, and re-read the section here again, and I ultimately think the phrasing is fine as is. Thanks for flagging up...
@SpectralPixel if you let me know what the specific issue was with this PR, I’m happy to fix that up along with the wrapping issue I am fixing!
No problem! 👍🏼 🎉
Thanks! Looks like you have at least one unclosed ``! Let me know when you have it fixed and I’ll do a review pass!
Ah, I see your last commit – that one is the problem, I expect. HTML blocks (like these, but also just like the old ``-based versions) are not subject to...