Chris Knoll

Results 131 comments of Chris Knoll
trafficstars

I'm looking at this, I thought it was understood that unless applyBindings makes the element, there will not be a contextFor it. In the filddle, apply binding is called but...

Thanks @fastfasterfastest , i wasn't challenging anything you said, just offering a possible backwards-compatible behavior that would make contextFor continue to work, but, as you point out, the 3.4 behavior...

Yes, you are right, of course, that each application can implement the same routine to find the closest context. I'll definitely make a note to have that implemented when we...

I've made a PR to add a `findContextFor` function, that I hope can be included in 3.5.1: #2447. I'm putting this under `ko.utils.findContextFor` unless there's a better place to put...

If all the existing tests work, isn't that enough to assert that it doesn't lead to a breaking change?

That is an excellent bit of legwork you did there, @fastfasterfastest .

Is there a way to do a sort of polyfill to native observables that would implement a read-hook? Full disclosure: I know very little about the underpinnings of the native...

If it works, why not make a PR and if it passes all the tests, why not let it apply to option groups? Sounds like a good feature.

I hear ya, @Coksnuss , that the authors are pretty strict about keeping the core features focused, and I agree with that position. In this case, however, the select/options binding...

The last release (3.4.0) was about 7 months ago, and so we're due for another release. There's been 20 commits to master since this release, so we'll likely see another...