Chris Mears

Results 21 comments of Chris Mears

Hmm, it looks like the date may have been stripped from the `created_at` and `updated_at` columns. I noticed that Excel did this because of how it formats dates (i.e. as...

Heya @Juicob! I'm doing some PR maintenance and closing for now. Happy to re-open; just let me know 🍻

Hi, @nnagle123! Thank you so much for the contribution! 🍻 It looks like there are several breweries that don't have full address information. Not your fault because we don't have...

Heya @nnagle123! I'm doing some PR maintenance and closing for now. Happy to re-open; just let me know 🍻

I think this may be more due to how the CSVs are formatted on open. That is, I think Excel likely causes this problem and the validation isn't fixing it.

Yeah, it almost certainly is lost and will need to be researched again. ☹️ I've also been exploring different ways to store the data in the database so that we...

Duh! 🀦 Great idea @CraigKelly ! πŸ™Œ And thank you for the PR! Still moving forward with SCDs πŸ˜„

@alexjustesen This is more of what I'm thinking about with the schema (I also updated the v1 to be more based on reality): https://dbdiagram.io/d/61d3c9533205b45b73d5a738 ``` Table breweries_v1 { id integer...

Oh, and after thinking about it, the whole "slug" thing should be handled programmatically or in a mapping table. Seems a little silly to hard-code it here.

@alexjustesen Sounds good! I think the whole `brewery_type` name came about because I ran into issues with `type` being reserved or something. Probably something automagic in Rails I wasn't using...