Chris Glein

Results 336 comments of Chris Glein

Some of the JS ones we'll get for free. On Fabric some of them might come for free with the border resolve helper thing. But we'll need to run through...

@danielayala94 , Jon had opened this issue awhile ago but I think your detailed inventory will replace this, agree?

- What warnings does core already emit vs. we would need to add for the Windows platform? - What can be handled by eslint validation?

Don't believe we implemented this on Paper; this is new functionality.

Addressed with https://github.com/microsoft/react-native-windows-samples/pull/1003

Getting Started appears to be correct now given #1003

Upstream PR hasn't been merged. @TatianaKapos can you follow up and ping them?

Based on this comment: https://github.com/microsoft/react-native-windows/pull/14784#issuecomment-2980639169 > We shouldn't be emitting these events from native. > > This looks like onPressIn was implemented incorrectly. Instead we should be removing these native...

Not sure if this is the missing support for https://github.com/microsoft/react-native-windows/issues/14646 There's a difference between "starts at the right size" and "the size can be changed by the user".

Commit that implements this and has workaround in place (fixed sized for all dialogs) here: https://github.com/chrisglein/artificial-chat/commit/b6c123b181e2531772decda79447a26f82bbc3ee