react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Remove override for NativeDOM pointer events casting double to int32_t

Open jonthysell opened this issue 11 months ago • 4 comments

Problem Description

In the upstream ReactCommon NativeDOM.cpp there are some implicit casts from doubles to PointerIdentifiers (int32_t) which flag as warnings for us. In the integration we disabled warnings, but that causes BinSkim to complain and fail our builds.

I fixed the issue by creating an override and performing the cast, but this issue should be resolved upstream.

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/14092

Link to commit

https://github.com/facebook/react-native/commit/0267ca0a4020bbe3226b27d0f6514febf1f0511b

Forked files

ReactCommon\react\nativemodule\dom\NAtiveDOM.cpp

Upstream PR

https://github.com/facebook/react-native/pull/48578

Build Configuration

None

jonthysell avatar Jan 08 '25 18:01 jonthysell

Upstream PR hasn't been merged. @TatianaKapos can you follow up and ping them?

chrisglein avatar Feb 12 '25 19:02 chrisglein

Merged on 2/20, can remove once we integrate past this date! :)

TatianaKapos avatar Feb 20 '25 21:02 TatianaKapos

@iamAbhi-916 I know you tried to remove the override in the last integrate and it failed some tests. Can you update what went wrong and what needs to be fixed upstream to remove this override?

TatianaKapos avatar Jun 03 '25 23:06 TatianaKapos

moving to 80

TatianaKapos avatar Jun 05 '25 00:06 TatianaKapos