Chris Blossom

Results 59 comments of Chris Blossom

FYI these checks are failing because mocha is timing out before the test has a chance to pass. Should not happen anymore if [#305](https://github.com/sarbbottam/eslint-find-rules/pull/305/files#diff-912d04f91de422a081173c41ff31335fR178) gets merged.

Sorry I'm not completely up to date here so what I'm about to suggest might not be relevant, but what about adding `.mjs` support behind a flag (disabled by default)...

Might want to drop node 12 as well because it is [https://github.com/nodejs/Release](no longer supported). Also should add the upcoming LTS v18 to the test matrix.

> I don't want to drop support for Node 12 because at least one key user, Stylelint, still supports Node 12 and we don't have a reason of our own...

> https://github.com/facebook/docusaurus/pull/1839: We want v2 of clean-webpack-plugin that use webpack compile hook, unlike its v3 that uses emit hook. Using upstream clean-webpack-plugin will break our SSR setup and fail our...

@endiliey but the `compile` lifecycle works for your setup? What can we do here to fix this in the library. Maybe add an option for custom lifecycle clean patterns?

@endiliey I definitely agree this / any library doesn't need to satisfy all use cases, but this one can easily adapt to yours/others with similar issues. But that being said,...

You either need to set `cleanStaleWebpackAssets: false` or add negative patterns to `cleanAfterEveryBuildPatterns: ['!*.png']`.

@aaaatpdev Please clarify what you are asking. Are you asking if it is an issue to keep stale assets on disk? If so, that is completely up to you.

The reason is because you should be installing `@types/webpack` in a typescript project with webpack. Please provide a use case that you would install `clean-webpack-plugin`, but not webpack.