cosmiconfig
cosmiconfig copied to clipboard
davidtheclark
Prepare v8
Might want to drop node 12 as well because it is [https://github.com/nodejs/Release](no longer supported). Also should add the upcoming LTS v18 to the test matrix.
I don't want to drop support for Node 12 because at least one key user, Stylelint, still supports Node 12 and we don't have a reason of our own to drop support.
We have v18 in the test matrix -- did you have something else in mind? I'm open to whatever.
The js-yaml package doesn't strictly follow the YAML 1.2 spec. It supports some YAML 1.1 features.
https://github.com/unifiedjs/unified-engine/issues/65
Should that be considered? @davidtheclark
I don't want to drop support for Node 12 because at least one key user, Stylelint, still supports Node 12 and we don't have a reason of our own to drop support.
Because this is a breaking change with the new YAML parser- stylelint would need to bump to a new major to use it, right? I assume stylelint would drop unsupported node versions at the same time as a version bump.
We have v18 in the test matrix -- did you have something else in mind? I'm open to whatever.
Sorry, very limited cell phone service for the week so I missed that v18 was added.
If you’d like, I could work on updating dependencies before the version bump if that would be helpful. I would need a week or so though to find time.
The Stylelint's current test suite passes the next version 8 of cosmiconfig (this PR's branch). 🎉
See https://github.com/stylelint/stylelint/pull/6120
I don't want to drop support for Node 12 because at least one key user, Stylelint, still supports Node 12 and we don't have a reason of our own to drop support.
Because this is a breaking change with the new YAML parser- stylelint would need to bump to a new major to use it, right? I assume stylelint would drop unsupported node versions at the same time as a version bump.
I think it's possible that Stylelint's next major version will drop the Node 12 support (due to EOL), but the Stylelint team doesn't discuss anything about it yet.
Asking Stylelint about both yaml/js-yaml and Node version support over in https://github.com/stylelint/stylelint/issues/6101#issuecomment-1140465191.
Hi @d-fischer, the Stylelint team has been going forward to the next major v15.0.0.
It would be nice to release Stylelint v15, including a dependency on Cosmiconfig v8. I will be happy to help if there is anything I can do.
My plan is to wait a few more days (probably until Sunday) and then merge #282 (if nobody sends in a negative review) and #283 (if there are proper tests by then). I'm not 100% sure about edge cases that could change with ESM support, so I'd rather have that in a major version than a minor, and I also don't want to bump major too often. But if it takes too long to finish the PR with tests, I can surely go on with the release.
Thanks, I understand the situation and agree with your plan. I will review the PRs.