Chris Ballinger

Results 291 comments of Chris Ballinger

@holykou I hope you are aware of the GPL license of ChatSecure and that closed source commercial derivatives are not supported at this time.

I'm in favor of switching if possible, would be great to eliminate another dependency.

Overall it's looking pretty good to me! Some small typos I noticed on the first pass: - `+- (void)xmppRoomLight:(XMPPRoomLight *)sender didCreatRoomLight:(XMPPIQ *)iq;` - `+#import "XMPPRoomLightCoreDataSTorage.h"` Some other improvements: - I...

Is `rooms` meant to be publicly accessible and mutable to other modules or classes that may be operating on different threads? Although it would be an edge case, if two...

Looks good! I think your changes should prevent any issues and makes the intention of the API more clear. Ready for a PR?

Probably best to finish it all and submit a big PR to avoid potential confusion about a partial implementation

We are also seeing this crash. Changing to `__bridge_retained` and `__bridge_transfer` introduced even more crashes.

Not helpful. Please include a stack trace.

Here are my experiments so far: https://github.com/chrisballinger/BLEMeshChat We are working on a spec for transmitting larger amounts of data than the MTU (20 bytes)