Chris Awad comments

Results 7 comments of


                                            Chris Awad

contentType() and contentType(str) are confusing.

I'll have to try the RC for Javalin 5. In Javalin 4, ctx.req/ctx.rsp are the HttpServletRequest/Responses -- I guess we can access those directly. > In general if you need...

contentType() and contentType(str) are confusing.

> Do you mean that these should wrap `HttpServletRequest` and `HttpServletResponse` ? If Javalin is supposed to be a complete wrapper I would say yes. It would just make sense....

Improved debugging support

This can give you a look at a the point after a successfully completed stage: `DOCKER_BUILDKIT=1` `docker build --target -t test .` `docker run --rm -it test bash` But unlike...

Nothing shows in `Layer XXX_RAW` when calling `pretty_print` with `include_raw=True`

This is still a problem today. This function that's in packet doesn't work either. The assert checks that FRAME_RAW is in the packet, which it is, but self.frame_raw.value isn't valid....

Fixed ek packet parsing when there are repeated protocol layers + added raw to each layer

I needed raw for each layer, so I fixed this bug as well: https://github.com/KimiNewt/pyshark/issues/587 Also fixed packet.get_raw_packet() which wasn't working since XXX_raw values were not assessable

When parsing EK JSON message that contains multiple layers of the same type, add the list as separate layers

I have a fix here that handles this a little better and orders the layers the way it shows up in wireshark so its better when printing. Your fix also...

dnsmasq: failed to create listening socket for port 53: Permission denied

Everything is being run as root so it's not that. Also I think CentOS 7 doesn't limit privileged ports like newer distros do. I've added the cap_add parameters for ALL...