Chris Arcand
Chris Arcand
> I am kind of on the fence on this. Still seems a little dangerous, but it's not really SQL injection per se. I agree completely and can respect either...
@kbrock Will recheck this soon. @miq-bot assign @chrisarcand
Sadly the notification endpoints doesn't give information as to if the comment is an issue comment or a pull request review comment, which is a problem as you can have...
Sure; [here's the example from the API docs](https://developer.github.com/v3/activity/notifications/#list-your-notifications)
* Oh is that right? I figured that `type` would remain `PullRequest` (since it's referring to the `subject`, not the comment) and the comment (without the type) is the thing...
I'm tired of this being a thing, as it's plagued my workflow for literally years now. I was hoping GitHub would just distinguish between `review_requested` and `team_review_requested` in their [list...
Coincidentally, there is! A big one: https://github.com/octobox/octobox/pull/2028
Yeah this is a bummer. Thanks for finding the cause!
@shayfrendt Hi! > Here are a couple snippets of insight into that decision... Those are quite reasonable. > If notifications support was added to the GraphQL API in the future,...