octobox Add filter to distinguish between direct review requests and team review requests

Add filter to distinguish between direct review requests and team review requests

Open lukashlavacka opened this issue 6 years ago • 6 comments

Similar as there is filter for Mention and Team mention there might be a way to add filter for Review requested only for direct review requests and Team review requested for requests of a team you are part of.

🐞 Problem

Being able to differentiate between Review requested and Team review requested would help especially with reviews requested by CODEOWNERS feature vs reviews requested directly.

Aug 23 '18 15:08 lukashlavacka

Big +1 to this - I would greatly appreciate being able to distinguish when I personally must give a review, or when my team in general needs to give a review (it affects how I prioritize my work).

I think the v3 REST API response is enough to distinguish this - the single PR endpoint has both requested_reviewers and requested_teams.

Apr 08 '19 14:04 ahayworth

I'm tired of this being a thing, as it's plagued my workflow for literally years now. I was hoping GitHub would just distinguish between review_requested and team_review_requested in their list of Notification reasons, but it's been 2.5 years since review requests shipped and by this point I imagine it could be a breaking change anyway (and there's still no V4 Notifications API, I note...) 😕

I sat down and came up with a potential solution that I'll be alpha testing next week, and will submit it if all goes well. Some early screenshots: