chris48s

Some time back we added the ability to construct and apply an arbitrary filter param. See - https://github.com/badges/shields/pull/9193 - https://shields.io/blog/tag-filter I'm going to suggest the way we handle this is...

I'm not sure I understand the significance of that list of examples. Could you clarify?

I think adopting the same pattern we use for github releases would do the job for most cases. For example: ```js import { matcher } from 'matcher' const versions =...

Thanks for having a look at this. @calebcartwright - in terms of the concept (i.e: "do we think this feature is a good idea?", as opposed to "is this good...

OK, sounds reasonable. I'll put this one on my list to review the code then

I've had a look over this. Broadly, the implementation looks fine. I'll leave a few comments inline. We would need to add some documentation for this param. In the new...

In terms of naming, I'm slightly unsure what the best name for this param is either, but I'm keen to get this right as once it is out there, we're...

> where did we land as far as our target strategic direction with this one? My last comment was > add the `logoSize=auto` param as a first step and then...

I checked this out locally. I'm seeing that `logoHeight` is still exposed as a URL param http://localhost:8080/badge/gaming-ED1C24?logo=amd&labelColor=555&logoSize=auto&logoHeight=1 http://localhost:8080/badge/gaming-ED1C24?logo=amd&labelColor=555&logoSize=auto&logoHeight=100

Quick FYI. I deployed this to production today, but hit a bit of an issue. Its unrelated to this PR, but basically this happened https://github.com/badges/shields/issues/10077 but in production this time....