chris48s
chris48s
Thanks. Having a custom endpoint for this sounds good. Particularly if there is a public endpoint that returns data for any public projects and we don't need to implement auth...
Just thinking about this a bit more (particularly in the context of https://github.com/badges/shields/pull/10792 and https://github.com/badges/shields/issues/10805 ) I think `baseUrl` makes more sense as a name for this concept than `server`...
> would only fit if we include the scheme inside the parameter Yeah :+1: so to summarise https://github.com/badges/shields/issues/10805 - This param should always be a full URL including protocol:// -...
Just coming back to this: Another slightly different way to enforce HTTPS at the validation layer is to write ```js Joi.string() .uri({ scheme: ['http', 'https'] }) .custom(url => url.startsWith('http') ?...
I'm down with baseUrl 👍
I've updated the PR with 3 options: release (default), latest and comparableVersion. I still feel kinda like we're hanging the internals out there a bit more than I'd like. I'd...
Thanks for the comments. There's some useful suggestions here on names and docs which I'll try and incorporate over the weekend :+1: > I strongly believe that this default should...
The latest changes in this PR implement: - highestVersion strategy is the default using mvncmp library - filter param implemented when strategy=highestVersion - Backwards compatibility with legacy prefix/suffix params when...
I'm going to leave it open for a little while longer and see if anyone else wants to review it. If nobody pops up I will just go ahead and...
@jNullj since you have got the wind in your sails at the moment, perhaps you would have a quick look over the code on this one?