Christian Krudewig

Results 18 comments of Christian Krudewig

Thanks for the response. No worries, just opened the feature request because I found it logical to have in the backlog. Maybe I try a PR indeed at some point....

Hey @codesenberg, any chance to get this PR into master? Or anything I can do to make it easier for you to review? I tried to keep the changes minimal,...

As a preliminary solution I used my forked master branch to publish this feature: https://github.com/chr1st1ank/bombardier/releases/tag/v1.3.5 No offense meant. I just needed windows + linux builds of it on multiple machines....

@TwiN Any chance of including this? I tried to make it as consistent as possible with the existing code

> Could you add some tests? It isn't straight-forward with the certificates. What way would you prefer: - Add hardcoded test certificates to the repository (which is simple, but linters...

Alright. Now the code is almost fully tested with certificates which are generated on the fly. It was actually not as complicated as I expected. I didn't know that go...

@TwiN I added tests and updated from master again.

This is unfortunately still relevant and the workaround mentioned above by @lig and @thisch, using the internal `catching_logs()` function is no longer available. The "logger" parameter was removed in 3862b0b28d1dac1d9ea398fc6155ed5e6de5498c....

Great, yes the commit message did not look as if you would have expected this effect. Thanks for the quick response, let me know if I can be of any...

Thank you! That works perfectly for me. I just rearranged the code a bit and added a function which gives me the `record_tuples` of the caplog fixture. It is a...