chonghe

Results 35 comments of chonghe

I have done some testing on this and some comments below (`current` refers to the help texts that we have now, while `new` refers to the help texts from this...

> @chong-he thanks for the detailed review! I think i was able to fix the issues you brought up > > * the cli params are now listed in alphabetic...

> Do we really want to split flags and options? I never understand the UX benefit of doing so. IMO flags should either: > > * be sorted in alphabetical...

> Member > confused why the cli-check is failing. It's working for me locally 🤔 I will look into this

Some comments after taking another look: 1. Should `lighthouse boot_node --enr-address` take a value? For now, with `lighthouse boot_node --enr-address` it doesn’t return an error. 2. `lighthouse boot_node --network-dir dummy_directory`...

> thanks @chong-he > > 1. fixed, it should now return an error when a value isnt provided > 2. the random "9000" has been removed > 3. subcommands now...

> Nice! > > Could we add it into the `code-check` test? > > I recall grouping things improved the speed of CI and it seems this could fit under...

> can we run this conditionally, i.e. only for changes in markdown files? Yes, the `VALIDATE_MARKDOWN: true` is to only run this for markdown file. Got it from: https://github.com/super-linter/super-linter?tab=readme-ov-file#configure-super-linter which...

> Probably need to pass the actual linter first Yes I am still figuring out to make it pass the CI. I will also make the linter to be in...

> Ah, looks like this is failing to merge because of some formatting issues in `unstable`. @chong-he can you back-merge unstable to this branch, and then get CI passing again?...