lighthouse
lighthouse copied to clipboard
sigp
Markdown linter
Issue Addressed
- #5053
Additional Info
- Added a script
mdlint.shin./scriptsfolder. Only check the folder of./bookwhich is the Lighthouse book - Config file located in the same folder
./booknamed.markdownlint.yamlwhich the Markdown linter CLI automatically detects (Ref: https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#configuration) - Modify
Makefileandtest-suite.ymlto add the Markdown linter
Nice!
Could we add it into the
code-checktest?I recall grouping things improved the speed of CI and it seems this could fit under that test?
I will look into it, thanks!
can we run this conditionally, i.e. only for changes in markdown files?
Yes, the VALIDATE_MARKDOWN: true is to only run this for markdown file. Got it from: https://github.com/super-linter/super-linter?tab=readme-ov-file#configure-super-linter which states:
If you set any of the VALIDATE_[LANGUAGE] variables to true, super-linter defaults to leaving any unset variable to false (only validate those languages).
Probably need to pass the actual linter first
Yes I am still figuring out to make it pass the CI. I will also make the linter to be in the same check with code-check later
queue
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
requeue
✅ This pull request will be re-embarked automatically
The followup queue command will be automatically executed to re-embark the pull request
queue
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.
requeue
✅ This pull request will be re-embarked automatically
The followup queue command will be automatically executed to re-embark the pull request
queue
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.
Ah, looks like this is failing to merge because of some formatting issues in unstable. @chong-he can you back-merge unstable to this branch, and then get CI passing again? :pray:
https://github.com/sigp/lighthouse/actions/runs/9200347323/job/25306765265
Ah, looks like this is failing to merge because of some formatting issues in
unstable. @chong-he can you back-merge unstable to this branch, and then get CI passing again? 🙏https://github.com/sigp/lighthouse/actions/runs/9200347323/job/25306765265
Done, thanks!
queue
🛑 The pull request has been removed from the queue default
The pull request conflicts with at least one pull request ahead in queue.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.
requeue
❌ This pull request head commit has not been previously disembarked from queue.
queue
✅ The pull request has been merged automatically
The pull request has been merged automatically at 3070cb7c3982f8321bbeb33413009f8f928bdf8a