cholberg
cholberg
Thank you for the comments, Patrick. I have gone through and made changes accordingly. The only thing I would disagree with is your comment on not having to evaluate `cond_fn`....
Perfect, I rebased and squashed all the commits into a single big one. Quite a few tests are failing when I run it locally now, but I just wanted to...
> Hi! Maybe i am using it wrong but at the moment I can't get the root_finder to do smth. I get the same event times when i use the...
> Regarding my confusion: Maybe this is a bad idea but maybe it would make sense to have a warning if both a boolean `cond_fn` and a root finder are...
Ah, yes I forgot to handle the case where multiple `SubSaveAt` are passed. Should be fixed now with the latest commit. Let me know if that works for you.
You're right I did not account for the fact that `SubSaveAt.fn` could return a PyTree. Should be fixed now. At least your MWE works with the latest commit.
@dkweiss31, sorry for being a little unresponsive these last couple of days! I will be quite busy the next 2-3 days, but will try to look at it asap. @patrick-kidger,...
@dkweiss31, @patrick-kidger: I ran your MWE above with `steps=True` (I am assuming that is what you mean, but correct me if I am wrong). I actually did not notice when...
@LuggiStruggi: With the latest commits, your second example seems to work for me :)
As far as I can tell, this happens exactly because your condition depends on `tnext`. This should be possible right now in `0.6.0` (at least not in a straight-forward way)...