Chris Morgan

Results 252 comments of Chris Morgan

Hello @TDA-2030 ! Did you see my msg above? If this looks ok I can refactor and submit a PR.

@TDA-2030 in the case where we wanted to share the player code between factory and mp3_demo, how would/should that work? Should that be a component? I'll be working from the...

Asked and got an answer for this on stack overflow, https://stackoverflow.com/questions/57634445/how-do-you-change-the-tick-options-for-ng2-charts-at-runtime/57634770?noredirect=1#comment101752598_57634770 but this doesn't explain why it isn't possible to change the lineChartOptions at runtime and have angular detect and...

I've got some fixes and cleanups that I missed and I'm adding wav support now. I'll msg here when its pushed and ready for review.

@TDA-2030 any reason that esp-adf wasn't used initially? I was unaware that esp-adf was so developed when I started on this a few weeks ago. Looking at it looks like...

@TDA-2030 makes sense, appreciate the info. I'm getting close to having the audio_component ready. It's simple and fully open source, so it should have some utility for some people that...

@TDA-2030 alright, here is the next rev and I think ready for review. For my other use case I'm going to integrate another audio codec, a TI one, and that...

> > For my other use case I'm going to integrate another audio codec, a TI one > > Can you share some information about the audio codec you mentioned?...

@TDA-2030 I should probably list out some of the improvements in the audio side. - mp3 playback finishes the song now, previous implementation I think would stop and not play...

Hi @TDA-2030 any chance to take a look at this PR? I was hoping to get it moving along the review and merging process.