Chris Morgan

Results 252 comments of Chris Morgan

I’m guessing it can do better. I’ll be profiling this weekend and see how much I can squeeze out of it. On the size topic if there are columns we...

@Bouni I'm on OSX and wanted to take a look at fixing this. How to get kicad plugin manager to use the local cloned repo for easy dev iteration? How...

Ahh perfect, this helps a ton and of course on the feature branch. > On Jul 21, 2023, at 1:32 AM, bouni ***@***.***> wrote: > > > Its actually pretty...

Fyi the path ended up being: /Users/cmorgan/Documents/KiCad/7.0/scripting/plugins Discovered when trying to figure out why it wasn’t showing up and then clicked on “Reveal plugins folder in finder”. > On Jul...

@Bouni alright so I'm able to edit and reload and looking into the issue. It appears that the toolbar tools added with the 2.0 scale factor (the value of self.scale_factor)...

@Bouni you know, a scale factor of 1 looks perfect here, screenshot attached. Maybe this scaling isn't necessary anymore now that wxwidgets is high dpi aware? ![image](https://github.com/Bouni/kicad-jlcpcb-tools/assets/1211904/98c584de-6cc0-47ef-86ec-9796a456e277)

@Bouni it is 2.0 here. Looking at how things render it doesn't seem correct though to scale icons by that amount.

![image](https://github.com/Bouni/kicad-jlcpcb-tools/assets/1211904/938821c7-6519-4656-8193-668dabbcf78f)

From this temporary code added to mainwindow.py: ``` self.logbox.write(f'{self.scale_factor}') self.logbox.write(f'scale factor {self.window.GetDPIScaleFactor()}') ```

@Bouni looks good here for me. Agree that it doesn't seem like osx needs the scaling for whatever reason, maybe because wxwidgets handles it somehow.