Christopher Jeffrey (JJ)
Christopher Jeffrey (JJ)
Ah, the joys of windows. Install VS C++ 2010 Express - BSOD on boot. I'll try again with a new image some other time.
@dbkaplun, all mouse events, or just "all motion"/"mousemove events"? Tmux 2.0 (if you're using it) no longer supports "all motion" so I had to add a strange workaround for it,...
Also, make sure you have the latest blessed (that includes the tmux 2.0 workaround if you're using it).
Alright, I'll have to play around with this on iTerm2 right quick.
Added a new commit to further optimize base64Write. This logic is basically how the node.js c++ code works internally. It requires no string preprocessing (`str.replace`, `str.split`, `str.indexOf`, etc) which gives...
Done. Force pushed so this is now the isolated PR. edit: I can rebase on master and force push again once you merge #352 if need be.
New base64 implementation using atob/btoa pushed.
After thinking about it, all of this `atob`/`btoa` inconsistency is really bugging me. I'm considering switching back to the custom base64 impl. Although harder to review, it provides consistent behavior...
@dcousens, I think I will switch this PR back to my custom base64 implementation. The more I think about it, the more I don't like `atob/btoa` for the following reasons:...
> This library should be using whatever underlying native functions exist, as that is what users expect. Fair enough. > I don't understand this, we should know that the input...