Christopher Jeffrey (JJ)

Results 182 comments of Christopher Jeffrey (JJ)

> Is the purpose of the meta file simply to hold the key? Yes, and the key is there to prevent a very specific kind of attack on the tree....

Also note that this could probably also be fixed by ensuring that values are never written on the same boundary that meta roots are (pad them by 1 byte or...

> I've started a port in go That's totally awesome by the way. :) Are you porting the radix tree or the simplified trie?

> I'm porting the optimized version of the simplified trie. _get and _insert functional, now working on the store piece. Cool. > Hmmm.... looks like I probably should have started...

Yeah, the serialization enforces most of the checks in `isSane()` already. A lot of the sanity checks are just there on account of my paranoia.

> Nice work on this repo Thanks. > my own LevelDB-based tree implementation in my module merk Very cool. Never saw this before. > it would be nice if it...

Wow, totally awesome! Now we just need a C implementation and we have all the bases covered. :)

I noticed you added `flags` as a member of the node struct in the rust impl. That `flags` field probably isn't as necessary for rust. In node.js it's just meant...

@tmcc-h, I was not aware any platforms used something other than pkcs padding. OpenSSH uses pkcs padding for encrypting private keys. Did that fix work for you? If so, what...

I'd prefer not to skip it (I think that may break other things). I'm trying to find some information on this now. It looks like `101` a GNU extension for...