urkel icon indicating copy to clipboard operation
urkel copied to clipboard

Proof fields not used.

Open davebryson opened this issue 7 years ago • 1 comments

proof.isSane() checks for nil values for the type deadend. Is there even a need for this? Looking through the code it appears there's no possible way for key,value,hash to ever be set for deadend. Is it simply good enough to check for the type without testing the unused fields? Or are these fields placeholders for future reference?

davebryson avatar Sep 04 '18 18:09 davebryson

Yeah, the serialization enforces most of the checks in isSane() already. A lot of the sanity checks are just there on account of my paranoia.

chjj avatar Sep 30 '18 08:09 chjj