chivesrs

Results 18 comments of chivesrs

@svenpaulsen @SGalbierz Any chance you can get a license on this repo?

Yup I just saw this happen in our project as well, especially for the `ts3.1/` typings. I think the right thing to do here is to unblock users from using...

I go as far as to say, this is a bug in the typings if it means users are getting type errors when they shouldn't.

I had a PR open against Jasmine and the definition owners decided against making the change. The current workaround is to use `jasmine.NonTypedSpyObj` or `jasmine.Spy`. See https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jasmine/ts3.1/jasmine-tests.ts#L1762

It does not work unfortunately. It's worse now, in the previous version I could make things happen by tabbing to the "next" button and then the carousel would render. Now...

@santoshyadavdev just checking on this

@santoshyadavdev what do you reckon we should do here? Should I rebase and do my best to get the commit reverted and fix merge conflicts? Something else?

I've resolved the merge conflict but unfortunately had to revert #458, I tried to preserve the PR as best as I could but I think it depends too much on...

@luca-peruzzo the code I have is internal to Google so it's not super easy for me to post it here. I tried your changes out yes on both my app...