Results 41 comments of chirsz

Maybe changing `char* argv[]` to `const char* const* argv` is enough. Non-const arguments would be auto converted to const type.

The "fixed literals" means the string literals *explicitly appearing*. >The final `_` indicates that other string literals and regular expressions that appear elsewhere in the grammar (e.g., `"("` or `"22"`)...

I find `=>@L` and `=>@R` in the source code, what's these meaning?

It seems that you can use `if` in before the action: ``` Enclosed: () = { LP RP if T == "a" => (), LB RB => (), } Test:...

Why don't allow "none" `colorSpaceConversion` when `createImageBitmap`? https://github.com/denoland/deno/blame/c5193556242117737fc3ba95ee3692b7831ca04a/ext/canvas/01_image.js#L307-L309

Is this a bug? I think the alpha value do not need to multiply 255. And why there need a `is_not_premultiplied` flag calculated from every pixels? https://github.com/denoland/deno/blame/c5193556242117737fc3ba95ee3692b7831ca04a/ext/canvas/lib.rs#L86

For [`ImageBitmap `](https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmap): - `ImageBitmap` is designed for immutable bitmap data stored in GPU (but not necessary, for example, Firefox do not store the data in GPU)[^1][^2], so it has...

We could hold the `GPUDevice` object in a `ImageBitmap` object when the underlying resource is a `GPUTexture`. When we want to perform some operations, we first check whether the devices...

理想情况下的主分支中: 1. 每个 commit 应当保持代码合法可构建,且只修改必要的一部分,以方便 BUG 查找; 2. PR 在合并时应该 rebase 到最新提交并按照第一条所说合并 commit;

@wysaid 咱们搞个审 PR 的流程吧,每个 PR 指定一个负责人来审,不然老是吊着。