sv-tests icon indicating copy to clipboard operation
sv-tests copied to clipboard

Builds broken

Open wsnyder opened this issue 10 months ago • 6 comments

The dependabot updates have been broken since ~ Jan 6, so all data is a month stale. Might this get fixed?

Or at least the verilator version updated if there's something hard to fix elsewhere, as I'd like to get back to regular checks that Verilator updates are not breaking any old passing tests. (Every few months sv-tests would find something that regressed - so well appreciate being able to check!)

Thanks

@tgorochowik et al.

wsnyder avatar Feb 25 '25 02:02 wsnyder

Thank you for the report! We'll take a look

tgorochowik avatar Feb 25 '25 09:02 tgorochowik

Ping. For some reason last dependabot build is here:

https://github.com/chipsalliance/sv-tests/pull/7022

I don't see any more recent for Verilator though there are regular changes. Thanks for investigating.

wsnyder avatar Apr 26 '25 01:04 wsnyder

Ping & attn @tgorochowik. I appreciate it's hard to find time to do maintenance, so if there isn't time to support sv-tests, I'd suggest the scheduled jobs be disabled versus reruning every night with the same stale information (as it "looks" recent given run date is current).

Note #7036 is latest, though still from April.

wsnyder avatar Jun 11 '25 01:06 wsnyder

Thank you for the reminders, unfortunately dependabot is not open source so it's hard to fully grasp what is happening, it does create PRs for other submodules but for whatever reason refuses to bump Verilator without reporting any issues or errors.

We'll investigate it once again and if nothing helps then maybe we'll add verilator under a different path to see if dependabot picks it up again?

tgorochowik avatar Jun 11 '25 08:06 tgorochowik

Looks like it's not just some dependabot pulls. The whole CI action seems busted for about a week now, due to "The job was not acquired by Runner of type self-hosted even after multiple attempts"

Definitely needs someone to spend a little bit of time on maintenance here. The test suite is nice, it would be a shame to just let it rot away.

MikePopoloski avatar Jun 13 '25 13:06 MikePopoloski

The CI issue is a separate thing and something new, the infra team is looking into this

tgorochowik avatar Jun 14 '25 14:06 tgorochowik

Dependabot works again, see #7240 and other RPs.

Apparently there is a bug in dependabot which makes it miscalculate the number of open PRs and prevents it from opening new PRs, this seems to have helped: https://github.com/chipsalliance/sv-tests/commit/41acf52030b5d43876e9c722f7599cd76801415a

tgorochowik avatar Jun 25 '25 14:06 tgorochowik

Thanks. FWIW now have 28 new passes for Verilator, and as I feared Verilator broke 3 that used to pass we need to look into.

wsnyder avatar Jun 26 '25 00:06 wsnyder