sv-tests icon indicating copy to clipboard operation
sv-tests copied to clipboard

filter for test coverage

Open Prahitha opened this issue 3 years ago • 7 comments

note: the filters will temporarily be at the end of the table -> $(column.footer()).empty() it is not fully implemented yet. the column.draw() inside the conditional statements doesn't work and needs some work.

Prahitha avatar May 25 '21 17:05 Prahitha

Note: Still a WIP Here is a small demo of what it does, there are a few bugs (like the one I paused at in the middle of the video) https://user-images.githubusercontent.com/44160152/120211208-4cffc400-c24e-11eb-8011-6da912c8f8da.mp4

(the select dropdown was not recorded in the screen recording) For the first column, I selected all (i.e., all test cases passed) and then selected 0 for the next column. This basically filters from the result of the previous one, if not cleared. To clear an active filter, the empty select option has to be selected.

Prahitha avatar May 31 '21 15:05 Prahitha

CC @hzeller

tgorochowik avatar Jun 01 '21 10:06 tgorochowik

thanks! so the position of the drop-downs definitely has to change and I planned on working on it once the functionality seemed okay. and, I believe it's a logical and because it filters out from the previous result only. i'll look into other ways if it's not as intuitive, please let me know

Prahitha avatar Jun 01 '21 10:06 Prahitha

below is a demo of how the toggle looks and works. also, just to clarify, the filtering is currently logical and but can support logical or too. any suggestions on how to implement it differently are welcome. thanks!

https://user-images.githubusercontent.com/44160152/120515413-e9130200-c3eb-11eb-9729-75fc00afabd5.mp4

Prahitha avatar Jun 02 '21 16:06 Prahitha

Compared test results

tool new_failures new_passes added removed not_affected
Slang 0 7 0 0 4861
YosysSv 0 0 0 0 4868
Icarus 0 0 0 0 4523
Verilator 0 339 0 0 4529
Verible 0 0 0 0 4523
Yosys 0 1 0 0 4867
moore 0 0 0 0 4623
Sv2v_zachjs 1 0 0 0 4622
UhdmYosys 2 2 0 0 4519
Surelog 0 0 0 0 4868
moore_parse 0 0 0 0 4623
tree_sitter_verilog 0 0 0 0 4523
Odin 0 0 0 0 4623
VeribleExtractor 0 0 0 0 4523
UhdmVerilator 0 0 0 0 4868
sv_parser 0 0 0 0 4623

github-actions[bot] avatar Jun 02 '21 17:06 github-actions[bot]

Thanks for the detailed explanation! I've attached an image below to confirm if I'm understanding properly. Please let me know, thanks image

Prahitha avatar Jun 07 '21 09:06 Prahitha

Hmm, not exactly, please see the attached diagram, the steps are split to separate drawings, hopefully it will be easier to understand what I mean sv tests filtering

tgorochowik avatar Jun 07 '21 10:06 tgorochowik