rocket-chip icon indicating copy to clipboard operation
rocket-chip copied to clipboard
verified publisher icon chipsalliance

bump json-jackson to 4.0.5

Open sequencer opened this issue 3 years ago • 2 comments

this PR make RC be able to compile against FIRRTL 1.6.X after chipsalliance/firrtl#2519 merged. This should be merged as a part of 1.6.X bumping. Type of change: other enhancement Impact: no functional change Development Phase: implementation Release Notes bumping jackson to 4.0.5

sequencer avatar Apr 23 '22 21:04 sequencer

Hopefully, this no longer throws an error once the json4s-native v4.x-dependent version of FIRRTL is being used by RC. Since RC currently uses FIRRTL 1.5 (which is on json4s-native v3.x), I'm guessing we can't upgrade RC's json4s-jackson to v4.x until a Chisel v3.x release that uses FIRRTL 1.6-SNAPSHOT with a dependency on json4s-native v4.x.

If that is the case, I'm wondering if there's some way to rely on FIRRTL's json4s-native version to determine the jackson version in the build dependency to avoid this failure.

michael-etzkorn avatar May 15 '22 19:05 michael-etzkorn

this PR only can be merged after x.6 Chisel/FIRRTL releasing.

sequencer avatar May 16 '22 02:05 sequencer

fixed in #3243

sequencer avatar Feb 16 '23 04:02 sequencer