fpga-tool-perf icon indicating copy to clipboard operation
fpga-tool-perf copied to clipboard

Results visualization: add possibility to hide lines

Open acomodi opened this issue 2 years ago • 9 comments

At the moment there is no possibility to hide the lines in the charts corresponding to the various toolchains.

Screenshot from 2022-04-13 09-16-09

The idea is to be able to click on the colored line belonging to a particular toolchain and disable all the lines corresponding to the particular toolchain.

For context, the results directory contains the code to gather and generate the HTML representation of all the results produced by the FPGA tool perf CI.

acomodi avatar Apr 13 '22 07:04 acomodi

I would love to contribute to this issue :D. May u assign this issue to me?

SiyaoIsHiding avatar Mar 09 '23 22:03 SiyaoIsHiding

@acomodi Just in case u didn't receive the notification

SiyaoIsHiding avatar Mar 17 '23 21:03 SiyaoIsHiding

Hi @SiyaoIsHiding I've assigned the issue to you

kgugala avatar Mar 18 '23 06:03 kgugala

@kgugala & @acomodi, Hello, I am working on this issue.

May I ask what should I put into the environment variable RESULTS_DIR when I build the visualization? The only clue I found is the CI file

      - name: Use gcloud CLI
        run: |
          cd results
          mkdir build-results
          gsutil cp gs://${{ secrets.GCP_STORAGE_BUCKET }}/*.json.gz build-results

But I do not have the access to your gcloud so I still don't know what I should put into this build-results folder.

Besides, may you simply give me an example of this build-results folder so that I can test the JS codes? I probably only need to modify the JS script inside the result folder, so I do not need to reproduce all your environment.

Thank you for your time and any advice will be appreciated.

Best, Jane

SiyaoIsHiding avatar Mar 19 '23 07:03 SiyaoIsHiding

Hi @SiyaoIsHiding, thanks for looking into this issue. Let me take a look and get back to you.

tmichalak avatar Mar 20 '23 17:03 tmichalak

@SiyaoIsHiding so actually for the purpose of solving this issue you could simply generate the data source files using the exhaust script, copy the resulting *.json.gz to the created build-results directory and run make preprocess and make build in the results directory. However, for simplicity I am uploading two *.json.gz files with the latest results. Copy them to the build-results directory and run the process and build targets. results-20230320-165233.json.gz results-20230320-085242.json.gz

tmichalak avatar Mar 20 '23 21:03 tmichalak

Thank you very much. I will work on it immediately.

SiyaoIsHiding avatar Mar 20 '23 21:03 SiyaoIsHiding

Hi, if the issue is still open, can I pick this up?

palaniappan-r avatar Feb 22 '24 13:02 palaniappan-r

yeah sure pls

SiyaoIsHiding avatar Feb 22 '24 16:02 SiyaoIsHiding