chisel
chisel copied to clipboard
Bundle elements ordering fix
TODO: support backwards compatibility with old ordering, perhaps by new chiselOption
After this change, all Bundle
elements will be ordered by the order of their declaration, including inheritance.
Fixes #4223. Straighten out the reversing of bundle elements by fixing the ordering during the compiler plugin. Remove runtime reversals and fix tests to reflect the new ordering.
Contributor Checklist
- [ ] Did you add Scaladoc to every public function/method?
- [ ] Did you add at least one test demonstrating the PR?
- [ ] Did you delete any extraneous printlns/debugging code?
- [ ] Did you specify the type of improvement?
- [ ] Did you add appropriate documentation in
docs/src
? - [ ] Did you request a desired merge strategy?
- [ ] Did you add text to be included in the Release Notes for this change?
Type of Improvement
- Bugfix
Desired Merge Strategy
- Squash: The PR will be squashed and merged (choose this if you have no preference).
Release Notes
All Bundle
elements will be ordered by the order of their declaration, including by inheritance.
Reviewer Checklist (only modified by reviewer)
- [ ] Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
- [ ] Did you mark the proper milestone (Bug fix:
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)? - [ ] Did you review?
- [ ] Did you check whether all relevant Contributor checkboxes have been checked?
- [ ] Did you do one of the following when ready to merge:
- [ ] Squash: You/ the contributor
Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
. - [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with
Create a merge commit
.
- [ ] Squash: You/ the contributor