chisel icon indicating copy to clipboard operation
chisel copied to clipboard

Emit FIRRTL bulk connects even for "input" wires

Open jackkoenig opened this issue 1 year ago • 0 comments

Fixes https://github.com/chipsalliance/chisel/issues/4218

One can question the need for this, as it's just making <> not error in a few more cases. The main motivation is that https://github.com/chipsalliance/chisel/pull/4205 causes some existing uses of <> that used to work no longer work. It's an unnecessary breakage that is fixed by this change.

Contributor Checklist

  • [ ] Did you add Scaladoc to every public function/method?
  • [x] Did you add at least one test demonstrating the PR?
  • [x] Did you delete any extraneous printlns/debugging code?
  • [x] Did you specify the type of improvement?
  • [ ] Did you add appropriate documentation in docs/src?
  • [x] Did you request a desired merge strategy?
  • [ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • [ ] Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • [ ] Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • [ ] Did you review?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?
  • [ ] Did you do one of the following when ready to merge:
    • [ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

jackkoenig avatar Jun 25 '24 20:06 jackkoenig