chisel icon indicating copy to clipboard operation
chisel copied to clipboard
verified publisher icon chipsalliance

Simple boring

Open schoeberl opened this issue 2 years ago • 8 comments

Contributor Checklist

  • [x] Did you add Scaladoc to every public function/method?
  • [x] Did you add at least one test demonstrating the PR?
  • [x] Did you delete any extraneous printlns/debugging code?
  • [x] Did you specify the type of improvement?
  • [ ] Did you add appropriate documentation in docs/src?
  • [x] Did you request a desired merge strategy?
  • [ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Please backport.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • [ ] Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • [ ] Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • [ ] Did you review?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?
  • [ ] Did you do one of the following when ready to merge:
    • [ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

schoeberl avatar Dec 04 '23 16:12 schoeberl

why adding this api?

sequencer avatar Dec 04 '23 16:12 sequencer

Because it is simpler than using a Seq and should be the default usage. This is for my students ;-)

schoeberl avatar Dec 12 '23 12:12 schoeberl

Why not using BoringUtils.bore(source)

sequencer avatar Dec 12 '23 13:12 sequencer

Does this exist in 3.5/3.6?

schoeberl avatar Dec 12 '23 17:12 schoeberl

Why not using BoringUtils.bore(source)

This does only exist in 6.0, not even in 5.1 or 3.6. If this is backported to 5 and 3 then this is probably a more elegant solution.

schoeberl avatar Dec 12 '23 17:12 schoeberl

This does only exist in 6.0, not even in 5.1 or 3.6. If this is backported to 5 and 3 then this is probably a more elegant solution.

Yes, comparing to introduce new API, I propose backporting this API to 5 and 3. But why not bumping version to 6? That's easy ;p

sequencer avatar Dec 13 '23 02:12 sequencer

This does only exist in 6.0, not even in 5.1 or 3.6. If this is backported to 5 and 3 then this is probably a more elegant solution.

Yes, comparing to introduce new API, I propose backporting this API to 5 and 3. But why not bumping version to 6? That's easy ;p

No chance at the moment to use firtool with 2nd semester students. And 6.0 is not out ;-)

schoeberl avatar Dec 13 '23 15:12 schoeberl

No chance at the moment to use firtool with 2nd semester students. And 6.0 is not out ;-)

RC is out ;p

sequencer avatar Dec 24 '23 07:12 sequencer