chisel
chisel copied to clipboard
Enforce port name uniqueness
Contributor Checklist
- [x] Did you add Scaladoc to every public function/method?
- [x] Did you add at least one test demonstrating the PR?
- [x] Did you delete any extraneous printlns/debugging code?
- [x] Did you specify the type of improvement?
- [ ] Did you add appropriate documentation in
docs/src
? - [ ] Did you state the API impact?
- [ ] Did you specify the code generation impact?
- [ ] Did you request a desired merge strategy?
- [ ] Did you add text to be included in the Release Notes for this change?
Type of Improvement
- code refactoring
- code cleanup
API Impact
Using suggestName
with the same name for multiple ports will now throw an error.
Backend Code Generation Impact
Desired Merge Strategy
- Squash: The PR will be squashed and merged (choose this if you have no preference.
Release Notes
Port name duplication and port name collision with other components like wires now throws an error instead of silently sanitizing the names.
Reviewer Checklist (only modified by reviewer)
- [ ] Did you add the appropriate labels?
- [ ] Did you mark the proper milestone (Bug fix:
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)? - [ ] Did you review?
- [ ] Did you check whether all relevant Contributor checkboxes have been checked?
- [ ] Did you do one of the following when ready to merge:
- [ ] Squash: You/ the contributor
Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
. - [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with
Create a merge commit
.
- [ ] Squash: You/ the contributor
@mergifyio update
update
✅ Branch has been successfully updated
This PR breaks playground regression CI in https://github.com/chipsalliance/playground/runs/7890002567, which should be fixed in the RC.