chisel-template icon indicating copy to clipboard operation
chisel-template copied to clipboard

Replace '-' with '_' in the initial template-cleanup.yml in 'build.sc'

Open SinaKarvandi opened this issue 1 year ago • 2 comments

If the repository name contains a '-', the CI/CD will fail because in the 'build.sc', the name of the object cannot include a '-'. So, I replaced it with a '_'.

image

SinaKarvandi avatar May 26 '24 06:05 SinaKarvandi

how about wrapping it with “`”?

sequencer avatar May 26 '24 06:05 sequencer

how about wrapping it with “`”?

Yeah, you're right, that's a better option. I changed it to wrap it with '`' and test it on my local repo, it works.

SinaKarvandi avatar May 26 '24 06:05 SinaKarvandi

Ideally we'd only include these backticks if they are necessary, but this fixes a real problem so we should merge.

jackkoenig avatar Jan 06 '25 19:01 jackkoenig