Surelog icon indicating copy to clipboard operation
Surelog copied to clipboard

Please allow to use external dependencies instead of bundling them

Open yurivict opened this issue 3 years ago • 3 comments

These are: antlr4, UHDM, flatbuffers, googletest.

yurivict avatar Dec 27 '21 16:12 yurivict

Can you motivate your ask? What problem are you facing? The only optional is antlr4, you can switch to the official antlr4 (See CMakeLists.txt).

But it looks like you should use the pre-packaged Surelog here that does work as a front-end to Yosys: https://antmicro.com/blog/2021/10/openlane-asic-build-flow-with-systemverliog-support/

alaindargelas avatar Dec 30 '21 19:12 alaindargelas

Stable dependencies like flatbuffers should be used through external packages for these reasons:

  1. In case security vulnerabilities would be later found in them - they should be fixed in one place, not in many bundled copies.
  2. Maintenance costs are lower when there's no bundling - compilation times are shorter, no need to update hashes/versions of bundled packages with each version update.
  3. In case the package requires/would require patches - they would be done in one place, vs. in all bundled copies.
  4. Bundling wastes CPU resources - compilation time grows exponentially with bundling because same software is recompiled again and again.

yurivict avatar Dec 30 '21 20:12 yurivict

Can you submit a pull request?

alaindargelas avatar Dec 31 '21 00:12 alaindargelas

Fixed with #3498

hzeller avatar Mar 15 '23 17:03 hzeller