chillenzer
chillenzer
Hi, here's a first batch of comments. These are more or less general comments, more detailed code comments as well as comments concerning the rest of the files will follow....
> I am not sure what exactly you mean, according to Github the PR does not touch `docs/source/models/collisional_ionization.rst` or `include/picongpu/fields/incidentField/profiles/DispersivePulse.hpp`? Okay. Then, ignore it. I pulled one specific commit last...
Who would be capable of answering your last question? Maybe @PrometheusPi?
From skim-reading through the linked doc page, I'd say what's missing there (as compared to the described workflow here) is version-controlling your changes. That sounds indeed like a very good...
Then, please, go ahead. I've prepared a board for you: ``` ------------- | | | | ------------- | | | | ------------- | | | | -------------
If only, I'd know. =P It's okay. I'll go ahead and fix it.
This is taken care of, right?
Added an identical fix for `tests/`. This does not (or only partially) solve #249.
@psychocoderHPC should we include this into the upcoming release or close?
We can close this, right?