picongpu icon indicating copy to clipboard operation
picongpu copied to clipboard

TransitionRadiation plugin openPMD output

Open finnolec opened this issue 2 years ago • 6 comments

This PR adds openPMD output to the Transition Radiation plugin. Additionally, as a Quality of Life feature, it made the virtual foil position a command line parameter and it changed the plugin to a multi-plugin.

During the refactoring I noticed, that the current value storage implementation is quite messy with the internal 3D to 1D mapping, but this is a task for a future PR. Also this plugin would profit, as soon as the openPMD standard allows axes with different unit systems. The plugin with the openPMD output is probably less flexible in defining the observers now, this might need to be changed in the future as well.

@BeyondEspresso @psychocoderHPC

finnolec avatar Aug 16 '23 13:08 finnolec

I can have a look at this after my holiday (Sep 4th)

franzpoeschel avatar Aug 25 '23 15:08 franzpoeschel

@finnolec what is the status of this pull request? may I test it or will there still be major changes and I should wait?

PrometheusPi avatar Dec 05 '23 09:12 PrometheusPi

I'm currently busy with different things, I will look into this PR in February again. I guess, you can wait until then with testing.

finnolec avatar Dec 05 '23 10:12 finnolec

@finnolec please finish this PR or can we close it?

psychocoderHPC avatar May 14 '24 07:05 psychocoderHPC

@PrometheusPi I implemented your suggestions, do you want to have another look?

finnolec avatar May 24 '24 08:05 finnolec

Who would be capable of answering your last question? Maybe @PrometheusPi?

chillenzer avatar Aug 20 '24 13:08 chillenzer